Skip to content

Conversation

@TimoGlastra
Copy link
Contributor

I added vitest as we use that in all other projects so it means we can have a consistent setup. I'm not a fan of the test output of node:test, as the debugging of what went wrong/ where an error occurred is a lot less cIear IMO.

I can revert the change to vitest again if we want to keep using node test (tests are passing now, so no need to debug anymore 😃)

Fixes #71

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra requested a review from a team as a code owner November 21, 2025 13:54
@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

🦋 Changeset detected

Latest commit: 45a2ec2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@openwallet-foundation/askar-react-native Minor
@openwallet-foundation/askar-nodejs Minor
@openwallet-foundation/askar-shared Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TimoGlastra
Copy link
Contributor Author

Okay, now 24 works but not 20 and 22 🤦

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra
Copy link
Contributor Author

It's not related to vite, I've tested it with node:test as well.

If someone else can figure out why this is failing, please enlighten me. Otherwise the "dirty" hack I can think of is to install both the old and new ffi libraries, and we use the old one for node up to 22 and the new one start from node 24

@TimoGlastra
Copy link
Contributor Author

If I run it just as a script, it seems to work fine, so I'm also not sure how to create a reproducable error from this

@TimoGlastra
Copy link
Contributor Author

It's not fully working for Node 24 as well.

Node 24 new ffi: 10/100 test runs failed
Node 20 new ffi: 100/100 test runs failed
Node 20 current main: 3/90 test runs failed (then it got stuck, and didn't proceed with the last 10)

I still think upgrading to Koffi or Node FFI RS would be a good option after looking into this. Or we should figure out if we're using the APIs of the current FFI library incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to FFI libraries to https://github.com/napi-ffi

2 participants