-
Notifications
You must be signed in to change notification settings - Fork 7
chore: update dependencies, add vite, support node 24, drop node 18 #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
🦋 Changeset detectedLatest commit: 45a2ec2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Okay, now 24 works but not 20 and 22 🤦 |
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
|
It's not related to vite, I've tested it with node:test as well. If someone else can figure out why this is failing, please enlighten me. Otherwise the "dirty" hack I can think of is to install both the old and new ffi libraries, and we use the old one for node up to 22 and the new one start from node 24 |
|
If I run it just as a script, it seems to work fine, so I'm also not sure how to create a reproducable error from this |
|
It's not fully working for Node 24 as well. Node 24 new ffi: 10/100 test runs failed I still think upgrading to Koffi or Node FFI RS would be a good option after looking into this. Or we should figure out if we're using the APIs of the current FFI library incorrect. |
I added vitest as we use that in all other projects so it means we can have a consistent setup. I'm not a fan of the test output of node:test, as the debugging of what went wrong/ where an error occurred is a lot less cIear IMO.
I can revert the change to vitest again if we want to keep using node test (tests are passing now, so no need to debug anymore 😃)
Fixes #71